Screen Dimming #651
Open
Screen Dimming #651
+64
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EbonJaeger
requested changes
Jan 5, 2025
src/daemon/screenlock.vala
Outdated
Comment on lines
127
to
146
| if (sleep_inactive_battery_type == "suspend" && sleep_inactive_battery_timeout != 0) { | ||
| output = "timeout " + sleep_inactive_battery_timeout.to_string(); | ||
| output += " 'if dbus-send --print-reply=literal --dest=org.buddiesofbudgie.BudgieScreenlock /org/buddiesofbudgie/Screenlock org.buddiesofbudgie.BudgieScreenlock.OnBattery | grep \"boolean true\" > /dev/null; then systemctl suspend; fi' "; | ||
| } | ||
|
|
||
| if (sleep_inactive_ac_type == "suspend" && sleep_inactive_ac_timeout !=0) { | ||
| output += " timeout " + sleep_inactive_ac_timeout.to_string(); | ||
| output += " 'if dbus-send --print-reply=literal --dest=org.buddiesofbudgie.BudgieScreenlock /org/buddiesofbudgie/Screenlock org.buddiesofbudgie.BudgieScreenlock.OnBattery | grep \"boolean false\" > /dev/null; then systemctl suspend; fi' "; | ||
| } | ||
|
|
||
| return output; | ||
| } | ||
|
|
||
| private string calculate_dim() { | ||
| isdimmable = this.power.get_boolean("idle-dim"); | ||
|
|
||
| if (!isdimmable) return ""; | ||
|
|
||
| return "timeout 30 'dbus-send --type=method_call --dest=org.buddiesofbudgie.BudgieScreenlock /org/buddiesofbudgie/Screenlock org.buddiesofbudgie.BudgieScreenlock.Dim' resume 'dbus-send --type=method_call --dest=org.buddiesofbudgie.BudgieScreenlock /org/buddiesofbudgie/Screenlock org.buddiesofbudgie.BudgieScreenlock.Undim' "; | ||
| } |
There was a problem hiding this comment.
Why do this when we have the methods available to us right in this class?
There was a problem hiding this comment.
'fraid I don't understand the comment. Here we are adding a timeout/resume to swayidle to perform the dim/undim stuff if its set in BCC to screendim
fossfreedom
force-pushed
the
screenlockdim
branch
from
c5d505d to
38519d8
Compare
That was resolved via the original screenlock PR - now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds power-dimming support if configured in BCC Power.
Also added on Evan's request, the ability to style gtklock via the gtklock config & style files if they exist in their home config/budgie-desktop folder.
i.e. if idle-dim is configured then swayidle will dim after 30 seconds and resume with the original set brightness.
It uses gsd-power to configure brightness settings.
Marking as draft until the screenlock PR is dealt with and then this will need rebasing.
Submitter Checklist
git rebase -i(if needed)